shukitchan commented on a change in pull request #32:
URL:
https://github.com/apache/trafficserver-ingress-controller/pull/32#discussion_r463419370
##########
File path: charts/TODO.md
##########
@@ -0,0 +1,35 @@
+# TODO for Helm support
Review comment:
Please add license to this file
##########
File path: charts/TODO.md
##########
@@ -0,0 +1,35 @@
+# TODO for Helm support
+Helm support for ATS Ingress Controller is still under development and can
only be used locally after building the following docker images:
+- ats_alpine
+- tsexporter
+
+After building the above images, do the following to install ATS Ingress using
Helm:
+1. `$ kubectl create namespace ats-ingress`
+ - Create the namespace where the ingress controller will be installed
+2. `$ helm install charts/ats-ingress --generate-name -n ats-ingress`
Review comment:
will this work without secrets ? from your specification below, it looks
like it cannot be optional. so you always need a TLS . Right ?
##########
File path: charts/TODO.md
##########
@@ -0,0 +1,35 @@
+# TODO for Helm support
+Helm support for ATS Ingress Controller is still under development and can
only be used locally after building the following docker images:
+- ats_alpine
+- tsexporter
+
+After building the above images, do the following to install ATS Ingress using
Helm:
+1. `$ kubectl create namespace ats-ingress`
+ - Create the namespace where the ingress controller will be installed
+2. `$ helm install charts/ats-ingress --generate-name -n ats-ingress`
+ - Use helm install to install the chart specifying the namespace created
in step one
+
+To install the ingress controller with TLS support, create a file named
`override.yaml` which contains the following two values:
+```yaml
+tls:
+ crt: <TLS certificate>
+ key: <TLS key>
+```
+and then:
+`$ helm install -f override.yaml charts/ats-ingress --generate-name -n
ats-ingress`
+
+## TODO for enabling Helm
+- [ ] Upload ats_alpine docker image to a public repository and replace
`image.repository` value in values.yaml
+- [ ] Upload trafficserver-exporter docker image to a public repository and
make the corresponding changes in `.Values.ats.exporter.image.repository`
Review comment:
it should be worded similar to the above right ?
Upload trafficserver-exporter docker image to a public repository and
replace `ats.exporter.image.repository` value in values.yaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
