bneradt commented on a change in pull request #7070:
URL: https://github.com/apache/trafficserver/pull/7070#discussion_r463723911
##########
File path: tests/gold_tests/tls/tls_client_cert.test.py
##########
@@ -25,8 +25,10 @@
cafile = "{0}/signer.pem".format(Test.RunDirectory)
cafile2 = "{0}/signer2.pem".format(Test.RunDirectory)
# --clientverify: "" empty string because microserver does store_true for
argparse, but options is a dictionary
-server = Test.MakeOriginServer("server", ssl=True, options = { "--clientCA":
cafile, "--clientverify": ""},
clientcert="{0}/signed-foo.pem".format(Test.RunDirectory),
clientkey="{0}/signed-foo.key".format(Test.RunDirectory))
-server2 = Test.MakeOriginServer("server2", ssl=True, options = { "--clientCA":
cafile2, "--clientverify": ""},
clientcert="{0}/signed2-bar.pem".format(Test.RunDirectory),
clientkey="{0}/signed-bar.key".format(Test.RunDirectory))
+server = Test.MakeOriginServer("server", ssl=True, options={"--clientCA":
cafile, "--clientverify": ""}, clientcert="{0}/signed-foo.pem".format(
Review comment:
I agree that looks better.
I was initially writing a reply saying I didn't think that I'd be able to
get autopep8 to format like this (it's not as configurable as clang-format is).
But playing around with things a little it looks like I can get that to work if
I pass in the `--aggressive --aggressive` argument to autopep8.
My latest commit uses that. I think it's better.
Thanks for the feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
