bneradt commented on a change in pull request #7077:
URL: https://github.com/apache/trafficserver/pull/7077#discussion_r464697884
##########
File path: tests/tools/plugins/ssl_hook_test.cc
##########
@@ -332,7 +332,7 @@ setup_callbacks(TSHttpTxn txn, int preaccept_count, int
client_hello_count, int
}
for (i = 0; i < sni_count; i++) {
cb = TSContCreate(&CB_SNI, nullptr);
- TSContDataSet(cb, (void *)(intptr_t)i);
+ TSContDataSet(cb, (void *)static_cast<intptr_t>(i));
Review comment:
I'm surprised this doesn't apply a C++ cast for the (void *) c-style
cast. Do you know why it doesn't?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
