maskit commented on a change in pull request #7100:
URL: https://github.com/apache/trafficserver/pull/7100#discussion_r468885181



##########
File path: proxy/http/HttpTransactCache.cc
##########
@@ -1309,7 +1309,7 @@ 
HttpTransactCache::match_response_to_request_conditionals(HTTPHdr *request, HTTP
 
   // If-Match: must match strongly //
   if (request->presence(MIME_PRESENCE_IF_MATCH)) {
-    int raw_etags_len, comma_sep_tag_list_len;
+    int raw_etags_len, comma_sep_tag_list_len = 0;

Review comment:
       > I think this is a different case, since the value is presumably set by 
value_get() in the next line.
   
   Oh, I missed it. However, that proved this line is confusing. The reason I 
wrote the example code is I didn't remember the behavior and needed to check 
it. If I forgot the behavior, I might add a new variable on this line and 
forget initializing it.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to