zizhong commented on a change in pull request #7117:
URL: https://github.com/apache/trafficserver/pull/7117#discussion_r471859984
##########
File path: iocore/hostdb/HostDB.cc
##########
@@ -1588,6 +1588,12 @@ HostDBContinuation::set_check_pending_dns()
this->setThreadAffinity(this_ethread());
HostDBContinuation *c = q.head;
for (; c; c = static_cast<HostDBContinuation *>(c->link.next)) {
+ if (c == this) {
+ Warning("Skip the insertion of the same continuation to pending dns");
+ return false;
Review comment:
hmm. 🤔
The set_handler only changes handler for this continuation. Since the
continuation is already in the pending dns list, there is no reason to do the
dnsEvent() again for this continuation.
Could you help me to understand how this will affect the other requests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
