masaori335 commented on a change in pull request #7148:
URL: https://github.com/apache/trafficserver/pull/7148#discussion_r479830929
##########
File path: proxy/http/HttpSM.cc
##########
@@ -5182,7 +5182,7 @@ HttpSM::do_http_server_open(bool raw)
opt.f_tcp_fastopen = (t_state.txn_conf->sock_option_flag_out &
NetVCOptions::SOCK_OPT_TCP_FAST_OPEN);
}
- opt.ssl_client_cert_name = t_state.txn_conf->ssl_client_cert_filename;
+ opt.set_ssl_client_cert_name(t_state.txn_conf->ssl_client_cert_filename);
opt.ssl_client_private_key_name =
t_state.txn_conf->ssl_client_private_key_filename;
Review comment:
These `ssl_client_private_key_name` and `ssl_client_ca_cert_name` has
the same issue potentially? Because they're `const char *` and setting pointers
in the `t_state.txn_conf` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
