maskit commented on pull request #7267: URL: https://github.com/apache/trafficserver/pull/7267#issuecomment-707475928
There was a confusion on what "active" means. This is my understanding after talking with Masaori. With this change, PING frames keep connections established until active timeout kicks in, even under graceful shutdown. Inactivity timeout does not kick in because there is activity (PING) on the connection. This is what I pointed out above. PING frames do not make a connection (or session) active state because PING does not initiate a transaction. Masaori thinks it would be nice if ATS could close a connection that do not have any ongoing transactions on `VC_WRITE_COMPLETE` event. Masaori is going to make another change for this in the future as part of #6877, but not now because he thinks it's not necessary. Correct me if I'm wrong, @masaori335 . I think waiting for `VC_WRITE_COMPLETE` is probably a right direction, however, keeping connections established under graceful shutdown does not sound like a good idea. The number of established TCP connections may not be 0, although you can check an ATS metric that indicates the number of connections that have ongoing transactions. Since truncated response is a pretty critical issue, taking this option for now may make sense, but you should understand what it can cause. I'm not sure when the additional change will be made, to be honest. There was no activity on #6877 for 3 months. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
