SolidWallOfCode commented on a change in pull request #7023:
URL: https://github.com/apache/trafficserver/pull/7023#discussion_r503957739
##########
File path: proxy/http/remap/PluginFactory.cc
##########
@@ -76,6 +76,18 @@ RemapPluginInst::doRemap(TSHttpTxn rh, TSRemapRequestInfo
*rri)
return _plugin.doRemap(_instance, rh, rri);
}
+std::shared_ptr<TSNextHopSelectionStrategy>
+RemapPluginInst::getStrategy()
Review comment:
There seems a bit of a name semantic mismatch - the outer is "get" but
the internal is "init". Does this initialize or just get?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
