maskit commented on a change in pull request #7282:
URL: https://github.com/apache/trafficserver/pull/7282#discussion_r509792976
##########
File path: proxy/http2/Http2ClientSession.cc
##########
@@ -299,18 +299,38 @@ Http2ClientSession::set_half_close_local_flag(bool flag)
}
int64_t
-Http2ClientSession::xmit(const Http2TxFrame &frame)
+Http2ClientSession::xmit(const Http2TxFrame &frame, bool flush)
{
int64_t len = frame.write_to(this->write_buffer);
+ this->_pending_sending_data_size += len;
+
+ // Force flush for some cases
+ if (!flush) {
+ // Flush if we already use half of the buffer to avoid adding a new block
to the chain.
Review comment:
Correct, and there is also receive window on H2 layer. Basically, the
total size of the buffered data will not be bigger than window size. Strictly
speaking, it can be bigger if we send H2 frames that are not under flow
control, but the sizes are vary small compare to DATA frame.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
