bneradt commented on a change in pull request #7259:
URL: https://github.com/apache/trafficserver/pull/7259#discussion_r518418730
##########
File path: proxy/http/HttpSM.cc
##########
@@ -2976,7 +2976,10 @@ HttpSM::tunnel_handler_server(int event,
HttpTunnelProducer *p)
{
STATE_ENTER(&HttpSM::tunnel_handler_server, event);
- milestones[TS_MILESTONE_SERVER_CLOSE] = Thread::get_hrtime();
+ // The following fixes up an intercept handler which doesn't set
TS_MILESTONE_SERVER_CONNECT by default.
Review comment:
To clarify that this comment applies to the check itself rather than the
whole conditional block, maybe reword as:
```
// An intercept handler may not set TS_MILESTONE_SERVER_CONNECT by
default. Therefore we only
// set TS_MILESTONE_SERVER_CLOSE if TS_MILESTONE_SERVER_CONNECT is set
(non-zero), lest
// certain time statistics are calculated from epoch time.
```
Just a suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
