shinrich commented on a change in pull request #7313:
URL: https://github.com/apache/trafficserver/pull/7313#discussion_r520156011
##########
File path: iocore/net/SSLConfig.cc
##########
@@ -426,20 +427,31 @@ SSLConfigParams::getClientSSL_CTX() const
return client_ctx;
}
+void
+SSLClientCoordinator::reconfigure()
+{
+ // The SSLConfig must have its configuration loaded before the SNIConfig.
+ // The SSLConfig owns the client cert context storage and the SNIConfig will
load
+ // into it.
+ SSLConfig::reconfigure();
+ SNIConfig::reconfigure();
+}
+
void
SSLConfig::startup()
{
- sslConfigUpdate.reset(new ConfigUpdateHandler<SSLConfig>());
- sslConfigUpdate->attach("proxy.config.ssl.client.cert.path");
- sslConfigUpdate->attach("proxy.config.ssl.client.cert.filename");
- sslConfigUpdate->attach("proxy.config.ssl.client.private_key.path");
- sslConfigUpdate->attach("proxy.config.ssl.client.private_key.filename");
+ sslClientUpdate.reset(new ConfigUpdateHandler<SSLClientCoordinator>());
Review comment:
I didn't create a SSLClientCoordinator::startup(). Only introduced the
class for the reconfigure case. We hadn't seem ordering problems on a process
start.
Probably to be consistent, we could insert SSLClientCoordinator in the
startup path as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
