masaori335 commented on a change in pull request #7328:
URL: https://github.com/apache/trafficserver/pull/7328#discussion_r526588719
##########
File path: iocore/eventsystem/P_UnixEThread.h
##########
@@ -96,11 +96,7 @@ EThread::schedule(Event *e)
// client VC, it can be HttpCacheSM etc. so save the flags
e->continuation->control_flags.set_flags(get_cont_flags().get_flags());
- if (e->ethread == this_ethread()) {
- EventQueueExternal.enqueue_local(e);
- } else {
- EventQueueExternal.enqueue(e);
- }
+ EventQueueExternal.enqueue(e);
Review comment:
The assumption is `e->ethread == this_ethread()` is always true, because
of `e->ethread = this;` in the beginning of this function, right?
Seems `enqueue_local(e)` should be called instead of `enqueue(e)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
