ywkaras commented on pull request #7347: URL: https://github.com/apache/trafficserver/pull/7347#issuecomment-735865009
> for args would be better to use --pristine with optional arg? > --pristine the same as --pristine=true OR --pristine=false to explicitly state default behavior? > Do we have any conventions for these args? > > Otherwise the changes themselves look good. Hmm do you mean @param=--pristine , or does the remap.config syntax allow for using -- before a parameter instead of @param? None of the current regex_remap parameters us -- as a prefix. The boolean parameters all use a "no-" prefix for false. https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/regex_remap.en.html ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
