vmamidi commented on a change in pull request #7386:
URL: https://github.com/apache/trafficserver/pull/7386#discussion_r544409477
##########
File path: proxy/http/HttpTunnel.cc
##########
@@ -1336,16 +1336,7 @@ HttpTunnel::consumer_handler(int event,
HttpTunnelConsumer *c)
c->producer->read_success = true;
// Go ahead and clean up the producer side
if (p->alive) {
- p->alive = false;
- if (p->read_vio) {
- p->bytes_read = p->read_vio->ndone;
- } else {
- p->bytes_read = 0;
- }
- if (p->vc != HTTP_TUNNEL_STATIC_PRODUCER) {
- // Clear any outstanding reads
- p->vc->do_io_read(nullptr, 0, nullptr);
- }
+ producer_handler(VC_EVENT_READ_COMPLETE, p);
Review comment:
I agree that the consumer never reads it. However, NetVC/CacheVC may
still try to read the outstanding data and signal the continuation that VIO is
holding and may result in a crash if that continuation is already cleared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
