maskit opened a new pull request #7434: URL: https://github.com/apache/trafficserver/pull/7434
We have two `init_server_ssl_ctx`, one in `SSLMultiCertConfigLoader` and the other in `QUICMultiCertConfigLoader`. They are almost same but there is a few difference. Some parts were removed or commented out from the one for QUIC because callback functions are not compatible with QUICNetVC in many cases. Duplicating entire function and removing some parts was the easiest way to make it work I guess. However, it's hard to maintain the both. You can't tell which part was removed, which part is missing, and which part is added only for one of them. This PR unifies the two functions by splitting the logic into small functions. `QUICMultiCertConfigLoader ` overrides some of the functions to disable the initialization processes. In the future the opposite thing may happen (SSLMultiCertConfigLoader has an empty function and only QUICMultiCertConfigLoader has the implementation). Ideally we may want to have an abstract MultiCertLoader but that would be next step. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
