maskit edited a comment on pull request #7405:
URL: https://github.com/apache/trafficserver/pull/7405#issuecomment-764464861
I ran tls-perf against ATS master with this patch (no additional changes
that I suggested) and there was only minor difference on HS/sec. My box and its
configuration are different form @c-taylor 's, but OpenSSL was the bottleneck
to me. Just switching SSL library from OpenSSL to BoringSSL improved HS/sec
much much more than applying this patch.
However, I do see a difference if I run `perf top`. With this patch the line
below disappears.
```
1.11% traffic_server [.] SSLSessionBucket::insertSession
```
I ran tls-perf like below. Handshake failed without specifying the list of
cipher suites.
```
tls-perf -T 20 -l 100 -t 10 --tls 1.2 -c
ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-CCM:ECDHE-ECDSA-AES128-CCM:ECDHE-ECDSA-AES256-CCM8:ECDHE-ECDSA-AES128-CCM8:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-CCM8:DHE-RSA-AES128-CCM8:DHE-RSA-AES256-CCM:DHE-RSA-AES128-CCM:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:AES256-GCM-SHA384:AES128-GCM-SHA256:AES256-CCM8:AES128-CCM8:AES256-CCM:AES128-CCM:AES256-SHA256:AES128-SHA2
127.0.0.1 443
```
If I specify TLS 1.3, I don't see ` SSLSessionBucket::insertSession` on
`perf top` even without this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
