shinrich edited a comment on pull request #6241:
URL: https://github.com/apache/trafficserver/pull/6241#issuecomment-769870712
initializing od to nullptr in the definition of CacheVC (P_CacheInternal.h),
seems to have solved the start up crash. I also verified that the start up did
not blow the cache. After start up, the canary machine has about the same
cache hit rate as its unchanged peer. I'm going back to a non-ASAN build, and
I'll let that machine run for another day or two.
@SolidWallOfCode pointed out that the constructor 0's "part" of the new
object. Is it possible that sizeof(CacheVC) changes with this PR? I don't see
how, but perhaps I'm missing something. Otherwise, I don't see how this
initialization logic differs with and without this patch.
```
CacheVC::CacheVC()
{
size_to_init = sizeof(CacheVC) - (size_t) & ((CacheVC *)nullptr)->vio;
memset((void *)&vio, 0, size_to_init);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
