SolidWallOfCode commented on a change in pull request #7445:
URL: https://github.com/apache/trafficserver/pull/7445#discussion_r568170201
##########
File path: iocore/net/ProxyProtocol.cc
##########
@@ -302,6 +307,184 @@ proxy_protocol_v2_parse(ProxyProtocol *pp_info, const
ts::TextView &msg)
return 0;
}
+size_t
+proxy_protocol_v1_build(uint8_t *buf, size_t max_buf_len, const ProxyProtocol
&pp_info)
+{
Review comment:
You should consider using `BufferWriter` here. I think it would
noticeably simplify the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
