ywkaras commented on a change in pull request #6455: URL: https://github.com/apache/trafficserver/pull/6455#discussion_r568188642
########## File path: plugins/regex_revalidate/regex_revalidate.cc ########## @@ -0,0 +1,729 @@ +/** @file + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "ts/ts.h" +#include "ts/remap.h" +#include "ts/experimental.h" +#include "regex.h" + +#include <cinttypes> +#include <cstring> +#include <ctime> +#include <getopt.h> +#include <limits.h> +#include <sys/types.h> +#include <sys/stat.h> + +#include <algorithm> +#include <iostream> +#include <map> +#include <memory> +#include <set> +#include <string> +#include <string_view> +#include <vector> + +#ifdef HAVE_PCRE_PCRE_H +#include <pcre/pcre.h> +#else +#include <pcre.h> +#endif + +namespace +{ +constexpr char const *const PLUGIN_NAME = "regex_revalidate"; +constexpr char const *const RELOAD_TAG = "config_reload"; +constexpr char const *const PRINT_TAG = "config_print"; + +#define DEBUG_LOG(fmt, ...) TSDebug(PLUGIN_NAME, "%s:%d " fmt, __func__, __LINE__, ##__VA_ARGS__) + +#define ERROR_LOG(fmt, ...) \ + TSError("(%s) " fmt, PLUGIN_NAME, ##__VA_ARGS__); \ + DEBUG_LOG(fmt, ##__VA_ARGS__) + +constexpr TSHRTime const CONFIG_TMOUT = 60000; // ms, 60s +// constexpr TSHRTime const CONFIG_TMOUT = 5000; // ms, 5 +constexpr int const OVECTOR_SIZE = 30; +constexpr int const LOG_ROLL_INTERVAL = 86400; +constexpr int const LOG_ROLL_OFFSET = 0; + +TSCont config_cont{nullptr}; +Regex config_re; + +void * +ts_malloc(size_t s) +{ + return TSmalloc(s); +} + +void +ts_free(void *s) +{ + return TSfree(s); +} + +struct Invalidate { + std::string regex_text{}; + Regex regex{}; + time_t epoch{0}; + time_t expiry{0}; + + Invalidate() = default; + + Invalidate(Invalidate const &orig) + { + regex_text = orig.regex_text; + epoch = orig.epoch; + expiry = orig.expiry; + regex.compile(regex_text.c_str()); + } + + Invalidate(Invalidate &&orig) = default; + Invalidate &operator=(Invalidate &&rhs) = default; + + Invalidate & + operator=(Invalidate const &rhs) + { + if (&rhs != this) { + regex_text = rhs.regex_text; + epoch = rhs.epoch; + expiry = rhs.expiry; + regex.compile(regex_text.c_str()); + } + return *this; + } + + ~Invalidate() = default; + + inline bool + is_valid() const + { + return regex.is_valid(); + } + + inline bool + matches(char const *const url, int const url_len) const + { + return regex.matches(std::string_view{url, (unsigned)url_len}); + } + + static Invalidate fromLine(time_t const epoch, Regex const &config_re, char *const line); +}; + +struct PluginState { + std::string config_file{}; + std::shared_ptr<std::vector<Invalidate>> invalidate_vec; + bool timed_reload{true}; + time_t config_file_mtime{0}; + time_t min_expiry{0}; + TSTextLogObject log{nullptr}; + + ~PluginState() + { + if (nullptr != log) { + TSTextLogObjectDestroy(log); + } + } + + bool fromArgs(int argc, char const **argv); + bool loadConfig(time_t const timenow, std::vector<Invalidate> *const newrules) const; + + void printConfig() const; + void logConfig() const; +}; + +Invalidate +Invalidate::fromLine(time_t const epoch, Regex const &config_re, char *const line) +{ + Invalidate rule; + + int ovector[OVECTOR_SIZE]; + DEBUG_LOG("'%s'", line); + int const rc = config_re.exec(line, ovector, OVECTOR_SIZE); + + if (3 == rc) { + int const regbeg = ovector[2]; + int const regend = ovector[3]; + + char const *const regstr = line + regbeg; + char const oldch = line[regend]; + line[regend] = '\0'; // temporarily inject null termination + + if (rule.regex.compile(regstr)) { + rule.regex_text = regstr; + rule.expiry = (time_t)atoll(line + ovector[4]); + rule.epoch = epoch; + } else { + DEBUG_LOG("Invalid regex in line: '%s'", regstr); + } + + // restore the line char* + line[regend] = oldch; + } + + return rule; +} + +void +get_time_now_str(char *const buf, size_t const buflen) +{ + TSHRTime const timenowusec = TShrtime(); + int64_t const timemsec = (int64_t)(timenowusec / 1000000); + time_t const timesec = (time_t)(timemsec / 1000); + int const ms = (int)(timemsec % 1000); Review comment: Why not convert these to static_cast? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
