SolidWallOfCode commented on a change in pull request #7485:
URL: https://github.com/apache/trafficserver/pull/7485#discussion_r582952464
##########
File path: proxy/ParentConsistentHash.cc
##########
@@ -389,6 +391,7 @@ ParentConsistentHash::markParentUp(ParentResult *result)
ink_atomic_swap(&pRec->failedAt, static_cast<time_t>(0));
int old_count = ink_atomic_swap(&pRec->failCount, 0);
+ ink_atomic_swap(&pRec->retriers, 0);
Review comment:
For 8 byte (or less) values there is no need for an atomic store because
it is intrinsically atomic. However, there is `std::atomic<T>::store` for the
general case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
