ywkaras commented on pull request #7598: URL: https://github.com/apache/trafficserver/pull/7598#issuecomment-803058430
> @ywkaras is going to change it to use std::hash and string_view I had forgotten that the reason I didn't use std::string_view as the unordered_map key (with default hash and compare) is that, because the key is the SNI servername, it must be case insensitive ( https://tools.ietf.org/html/rfc3546#page-8 ). I could normalize the servername to lowercase before doing the lookup here: https://github.com/apache/trafficserver/pull/7598/files#diff-a2fcfdba174f68b6444d283948e88441c38cfa09799fc67ae93fadf9e81429e0R203 . But that would require using non-standard variable length stack allocation (alloca() or a variable length array). It seems unlikely an extremely long SNI server name could be seen at this point (allowing for a stack blow DOS attack) but I guess I'd have to double check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
