shinrich commented on pull request #7618:
URL: https://github.com/apache/trafficserver/pull/7618#issuecomment-806155471
I don't think this is causing the connection count problem.
In HttpSM you see the pattern
```
server_session->set_inactivity_timeout(HRTIME_SECONDS(t_state.txn_conf->keep_alive_no_activity_timeout_out));
server_session->release(nullptr);
```
I'd suggest either, adding an ink_release_assert in
ServerSessionPool::releaseSession to verify that the timeout is currently set
to a non-zero value. And/or pass along the keep_alive timeout value as an
argument to release, so they are done together always.
I think the reason for the get/set is to make sure that the timeout is at
its full level. But truthfully, I don't see the path that would take the
session out of the pool and not go through the release path. So perhaps these
lines aren't necessary at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
