SolidWallOfCode commented on a change in pull request #7606:
URL: https://github.com/apache/trafficserver/pull/7606#discussion_r602546310
##########
File path: proxy/ControlBase.cc
##########
@@ -423,12 +422,12 @@ TextMod::print(FILE *f) const
void
TextMod::set(const char *value)
{
- free(this->text.data());
- this->text.set(ats_strdup(value), strlen(value));
Review comment:
With regard to the previous comment, if the string is being duplicated
already, why not `std::string`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
