maskit edited a comment on pull request #7667: URL: https://github.com/apache/trafficserver/pull/7667#issuecomment-813760982
`ats_scoped_action` sounds better to me in terms of naming, but it would cause another confusion. All `ats_scoped_*` are derived from `ats_scoped_resource`. Just adding `is_empty()` would be the simplest solution. Now I have another concern. ``` PendingAction pa = some_function(); pa->cancel() // A pa = nullptr; // B ``` The two lines, A and B, would basically the same thing, but line A does not clear `PendingAction::pending_action`. So `pa == nullptr` and `pa.is_empty()` would not return `true`. This is confusing, and can easily make bugs. I think we should not allow directly accessing the raw `Action *` in `PendingAction`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
