SolidWallOfCode commented on a change in pull request #7622:
URL: https://github.com/apache/trafficserver/pull/7622#discussion_r609046731



##########
File path: proxy/PoolableSession.h
##########
@@ -190,3 +204,39 @@ PoolableSession::FQDNLinkage::equal(CryptoHash const &lhs, 
CryptoHash const &rhs
 {
   return lhs == rhs;
 }
+
+inline void
+PoolableSession::enable_outbound_connection_tracking(OutboundConnTrack::Group 
*group)
+{
+  ink_assert(nullptr == conn_track_group);

Review comment:
       Not sure I'd do that - passing `nullptr` could be a way to disable 
connection tracking, and everything should function even if the value is 
`nullptr`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to