sudheerv edited a comment on pull request #7623: URL: https://github.com/apache/trafficserver/pull/7623#issuecomment-817063138
Nice and useful plugin to have. A comment/observation though - 1) Given that this is a remap plugin, it feels like the rate limiting of the transactions is effectively on the Origin transactions (at least, until H2 to Origin is supported) as opposed to the client side. [EDIT: Thanks Leif for correcting me, I totally missed Cache lookup as well which is also limited in addition to the Origin transactions, but, for some use cases, this still might be a bit too late). 2) I also wonder if this is potentially close to what https://docs.trafficserver.apache.org/en/9.0.x/admin-guide/files/records.config.en.html#proxy-config-http-per-server-connection-max does already. There is also a queueing support with the outbound connection tracking. Fwiw, we use a similar rate limiter plugin running in production with the difference being it is a global plugin (hooked at read-req and is run at the top of the plugin chain) and tracks concurrency against explicitly configured limits (ie not via remap.config). We've a bunch of business logic (including several sideways calls) that is run before remap state, so, queuing or limiting at remap is a little bit too late if we wanted to cap the resource usage more efficiently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
