shinrich commented on a change in pull request #7753:
URL: https://github.com/apache/trafficserver/pull/7753#discussion_r622550016
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -7331,17 +7331,13 @@ HttpTransact::what_is_document_freshness(State *s,
HTTPHdr *client_request, HTTP
TxnDebug("http_match", "[what_is_document_freshness] fresh_limit: %d
current_age: %" PRId64, fresh_limit, (int64_t)current_age);
- /////////////////////////////////////////////////////////
- // did the admin override the expiration calculations? //
- // (used only for http). //
- /////////////////////////////////////////////////////////
ink_assert(client_request == &s->hdr_info.client_request);
- if (s->txn_conf->cache_when_to_revalidate == 0) {
- ;
- // Compute how fresh below
- } else if (client_request->url_get()->scheme_get_wksidx() ==
URL_WKSIDX_HTTP) {
+ if (auto scheme = client_request->url_get()->scheme_get_wksidx(); scheme ==
URL_WKSIDX_HTTP || scheme == URL_WKSIDX_HTTPS) {
Review comment:
Is there much of a point to check the scheme here at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
