maskit commented on a change in pull request #7808:
URL: https://github.com/apache/trafficserver/pull/7808#discussion_r630665002



##########
File path: iocore/net/TLSSessionResumptionSupport.cc
##########
@@ -172,6 +172,30 @@ TLSSessionResumptionSupport::getSession(SSL *ssl, const 
unsigned char *id, int l
   return session;
 }
 
+SSL_SESSION *
+TLSSessionResumptionSupport::getOriginSession(SSL *ssl, const std::string 
&lookup_key)

Review comment:
       I'm OK with adding this for now, but I wonder if we can have only one 
`getSession` and lookup different caches inside it depends on the connection 
direction (SSL_is_server). I don't think we never call `getOriginSession` on 
client sessions (inbound connections), and vice versa.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to