SolidWallOfCode commented on a change in pull request #7809:
URL: https://github.com/apache/trafficserver/pull/7809#discussion_r631048475



##########
File path: iocore/net/NetEvent.h
##########
@@ -55,6 +55,9 @@ class NetEvent
   // Close when EventIO close;
   virtual int close() = 0;
 
+  bool has_error() const;
+  void set_error();

Review comment:
       Bikeshed - should be named `set_error_from_socket` - otherwise one 
wonders where the argument to set the error is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to