masaori335 commented on a change in pull request #7807:
URL: https://github.com/apache/trafficserver/pull/7807#discussion_r631507651
##########
File path: proxy/http/HttpCacheSM.cc
##########
@@ -283,6 +283,7 @@ HttpCacheSM::do_cache_open_read(const HttpCacheKey &key)
return ACTION_RESULT_DONE;
} else {
ink_assert(pending_action != nullptr || write_locked == true);
+ captive_action.cancelled = false; // Make sure not cancelled before we
hand it out
return &captive_action;
Review comment:
> The captive_action::cancel() passes through to cancel the
pending_action member of the HttpCacheSM.
https://github.com/apache/trafficserver/pull/7819#issuecomment-839860155
I missed this part. I agree we can't get rid of `captive_action`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
