cukiernik commented on pull request #7817: URL: https://github.com/apache/trafficserver/pull/7817#issuecomment-840516832
> Looks nice, but as long as this is being cleaned up, the symbolic constant `ts::NO_FD` should be used instead of literal "-1". Could you tweak that for me? Yes, I could, but legal is -1 https://man7.org/linux/man-pages/man2/open.2.html#RETURN_VALUE It is never compared to ts::NO_FD, but the copy is compared with AIO_NOT_IN_PROGRESS... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
