zwoop commented on a change in pull request #7843:
URL: https://github.com/apache/trafficserver/pull/7843#discussion_r635307932
##########
File path: iocore/dns/DNS.cc
##########
@@ -766,6 +766,8 @@ DNSHandler::failover()
ip_text_buffer buff;
Warning("failover: connection to DNS server %s lost, retrying",
ats_ip_ntop(&ip.sa, buff, sizeof(buff)));
}
+ // Make sure retries are done even if no more requests.
+ this_ethread()->schedule_at(this, DNS_PRIMARY_RETRY_PERIOD);
Review comment:
Yeh, that looks wrong, examining the code, _at vs _in is clear. If you
want to use _at, it would need to be
```
this_ethread()->schedule_at(this, Thread::get_hrtime() +
DNS_PRIMARY_RETRY_PERIOD);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
