ywkaras commented on a change in pull request #7765:
URL: https://github.com/apache/trafficserver/pull/7765#discussion_r635671684
##########
File path: plugins/cache_promote/cache_promote.cc
##########
@@ -110,7 +119,15 @@ TSRemapInit(TSRemapInterface *api_info, char *errbuf, int
errbuf_size)
return TS_ERROR;
}
- TSDebug(PLUGIN_NAME, "remap plugin is successfully initialized");
+ // Reserve a TXN slot for storing the calculated URL hash key
+ if (TS_SUCCESS != TSUserArgIndexNameLookup(TS_USER_ARGS_TXN, PLUGIN_NAME,
&TXN_ARG_IDX, nullptr)) {
Review comment:
Seems like this would always fail:
https://github.com/apache/trafficserver/blob/a0c267cdc88586679ccba4ec3e394f386d52f806/src/traffic_server/InkAPI.cc#L6330
Can't you just call reserve like a normal person?
https://github.com/apache/trafficserver/blob/a0c267cdc88586679ccba4ec3e394f386d52f806/plugins/esi/combo_handler.cc#L441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
