masaori335 commented on a change in pull request #7586:
URL: https://github.com/apache/trafficserver/pull/7586#discussion_r638447115
##########
File path: proxy/http/HttpSM.cc
##########
@@ -465,11 +465,8 @@ HttpSM::state_add_to_list(int event, void * /* data
ATS_UNUSED */)
if (ua_entry->read_vio) {
// Seems like ua_entry->read_vio->disable(); should work, but that was
// not sufficient to stop the state machine from processing IO events
until the
- // TXN_START hooks had completed
- // Preserve the current read cont and mutex
- NetVConnection *netvc = ((ProxyTransaction *)ua_entry->vc)->get_netvc();
- ink_assert(netvc != nullptr);
- ua_entry->read_vio = ua_entry->vc->do_io_read(netvc->read_vio_cont(), 0,
nullptr);
+ // TXN_START hooks had completed. Just set the number of bytes to read
to 0
+ ua_entry->read_vio = ua_entry->vc->do_io_read(this, 0, nullptr);
Review comment:
I got the same idea while digging another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
