bneradt commented on a change in pull request #7887:
URL: https://github.com/apache/trafficserver/pull/7887#discussion_r640767269
##########
File path: tests/gold_tests/headers/gold/bad_good_request_v10.gold
##########
@@ -0,0 +1,22 @@
+HTTP/1.0 400 Invalid HTTP Request
+Date: ``
+Server: ATS/``
+Cache-Control: no-store
+Content-Type: text/html
+Content-Language: en
+Content-Length: 219
+
+<HTML>
+<HEAD>
+<TITLE>Bad Request</TITLE>
+</HEAD>
+
+<BODY BGCOLOR="white" FGCOLOR="black">
+<H1>Bad Request</H1>
+<HR>
+
+<FONT FACE="Helvetica,Arial"><B>
+Description: Could not process this request.
+</B></FONT>
+<HR>
+</BODY>
Review comment:
I wonder whether this gold file is verifying too much? Any small changes
in this output, even by one character, will cause it to fail. Perhaps:
```
HTTP/1.0 400 Invalid HTTP Request
Date: ``
Server: ATS/``
Cache-Control: no-store
Content-Type: text/html
Content-Language: en
Content-Length: ``
``
<TITLE>Bad Request</TITLE>
``
Description: Could not process this request.
``
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
