sudheerv commented on pull request #7918: URL: https://github.com/apache/trafficserver/pull/7918#issuecomment-856402109
> I was thinking of the `UrlRewrite` object, which contains both the literal and regex remap rules, and is reference counted. I'm not sure what you mean by "duplicate the entire counts table during reload". If it's just an atomic counter per remap rule, there is no rebuilding for that. > Yeah, the problem is that, the regular map rules are stored as a Trie and there's no clean API from the Trie to iterate through. I was trying to avoid duplicating (maintaining 2 copies of this during a reload), but I ended up limiting the duplicate to just the the mapping entry to workaround this problem. I guess it's a decent tradeoff given your other observations. > It's not clear to me keeping the data between reloads is a feature. That means history distorts current data and it would become very hard to test new remap rulesets. Beyond that, if preservation were absolutely required, one could dump the current table just before doing the reload. +1 Yeah, I'm not really particular about this - the data is process scoped (not persisted by TS) and the collector that polls periodically will persist the data outside of ATS anyway, so I like this approach better as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
