shinrich opened a new pull request #8004: URL: https://github.com/apache/trafficserver/pull/8004
Found this while investigating #7838. According to https://en.cppreference.com/w/cpp/container/deque/pop_back#:~:text=std%3A%3Adeque%3A%3Apop_back&text=Removes%20the%20last%20element%20of,the%2Dend%20iterator%20is%20invalidated. After pop_back is called "Iterators and references to the erased element are invalidated". In the current logic, the increment is called on the old iterator after pop_back is called. I'm not 100% sure this is causing our crash. If most of the time only one item is evicted, this case won't happen very often and maybe most of the time you get lucky. I will get this patched rolled into our build. Even if it does not fix the crash the new logic is safer and looks cleaner. This closes #7838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
