SolidWallOfCode commented on a change in pull request #8066:
URL: https://github.com/apache/trafficserver/pull/8066#discussion_r673541736
##########
File path: src/traffic_server/InkAPITest.cc
##########
@@ -83,6 +83,29 @@
#define ERROR_BODY "TESTING ERROR PAGE"
#define TRANSFORM_APPEND_STRING "This is a transformed response"
+//////////////////////////////////////////////////////////////////////////////
+// These static asserts verify the hook vs event value relationship described
+// in the doxygen comment for TSHttpHookID.
+//////////////////////////////////////////////////////////////////////////////
+static_assert(TS_EVENT_HTTP_READ_REQUEST_HDR == TS_EVENT_HTTP_READ_REQUEST_HDR
+ TS_HTTP_READ_REQUEST_HDR_HOOK);
Review comment:
This is overkill. You want this, or the `REBASE` macro, not both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
