elsloo commented on a change in pull request #8088:
URL: https://github.com/apache/trafficserver/pull/8088#discussion_r677786941
##########
File path: include/ts/ts.h
##########
@@ -1778,6 +1778,14 @@ tsapi void TSHttpTxnServerIntercept(TSCont contp,
TSHttpTxn txnp);
@param addr Target address of the origin server.
@param tag A logging tag that can be accessed via the pitag field. May be
@c NULL.
@param id A logging id that can be access via the piid field.
+ @param buffer_index Index for read and write buffers used by PluginVC.
+ @param buffer_water_mark Number of bytes used as the water mark for
buffers used by PluginVC.
+ */
+tsapi TSVConn TSHttpConnectPlugin(struct sockaddr const *addr, const char
*tag, int64_t id, int64_t buffer_index,
+ int64_t buffer_water_mark);
Review comment:
@traeak I just pushed a commit that introduces a struct
(`TSHttpConnectPluginOptions`) to replace the function arguments, and the
`buffer_index` member now matches the type you suggest. That said, I am only
using that type in the API and its dependencies, and will update PR #8089 to do
the same if these changes are accepted.
The changes I made to the PluginVC interface that exist inside the core will
continue to use the `#defined` values; this seems to be in the spirit of how
these two synonymous things are used in practice (API vs `#define`ed). Do you
agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
