shinrich commented on pull request #8083: URL: https://github.com/apache/trafficserver/pull/8083#issuecomment-889173435
Right. Before your change, the code was setting C back to C. I assume in an attempt to ensure the full inactivity timeout was applied during the keep-alive period. But before calling ServerSessionPool::releaseSession, the caller had set the inactivity timeout to B (the override version of the keepalive timeout). Unfortunately, by the time we get to ServerSessionPool::releaseSession, the code does not have direct access to B. No access to the state machine. We could update the API, so B is passed along the release call chain, so it can be set in ServerSessionPool::releaseSession. Ultimately, the keep-alive timeout should really be overridable at the session level. But unfortunately, our existing override mechanism is centered around the HttpSM. We have talked in various meetings about making session more first class objects, but I'm afraid that is a bigger decision effort that this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
