rob05c commented on a change in pull request #8208:
URL: https://github.com/apache/trafficserver/pull/8208#discussion_r684288226
##########
File path: iocore/net/SSLSNIConfig.cc
##########
@@ -170,7 +170,7 @@ SNIConfigParams::Initialize()
if (!zret.isOK()) {
std::stringstream errMsg;
errMsg << zret;
- Error("%s failed to load: %s", sni_filename, errMsg.str().c_str());
+ Emergency("%s failed to load: %s", sni_filename, errMsg.str().c_str());
Review comment:
Yeah, I guess that's fine. On startup, you're not breaking any running
traffic. Reload is a harder decision: do we kill the app and break running
traffic in the face of a potential security/access concern?
I guess not breaking running traffic is an acceptable choice here. @alficles
^
I tried to see what other configs like ip_allow.yaml do. It throws an
exception and crashes ATS. But I'm not sure if that's intentional or desirable.
I also feel like a running config changing to be malformed is at least a
little less likely. It seems highly likely to me that a user might create a
file wrong and never notice the log error; it seems slightly less likely that a
user would create a correct file, and later malform it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
