bneradt opened a new pull request #8246:
URL: https://github.com/apache/trafficserver/pull/8246
Our log filter mechanism for IP addresses was broken. This fixes the
matching mechanism so it compares IP addresses with log fields
correctly.
Fixes #6405
---
The LogFilterIP::is_match mechanism stopped working at some point in the
past. That is what the linked issue observes. I fixed this by addressing the
warning in the comment that was in that function:
```
// This is bad, we abuse the fact that the initial layout of
LogFieldIpStorage and IpAddr
// are identical. We should look at converting the log stuff to use
IpAddr directly.
```
Those structures have diverged such that they do not match between each
other anymore. I thus converted the use of LogFieldIp* types to IpAddr.
@SolidWallOfCode : you wrote that code (and the comment) initially. Can you
please verify that what I'm doing here is what you had in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
