jrushford commented on a change in pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#discussion_r689793759
##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -108,7 +110,12 @@ NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
} else if (ring_mode_val == exhaust_rings) {
ring_mode = NH_EXHAUST_RING;
} else if (ring_mode_val == peering_rings) {
- ring_mode = NH_PEERING_RING;
+ ring_mode = NH_PEERING_RING;
+ YAML::Node self_node = failover_node["self"];
+ if (self_node) {
Review comment:
@ywkaras Is this correct, `self` is part of the failover node`. I'm not
sure how this works in identifying the self host. Maybe I'm missing something.
In testing, I'm looping when the self host is selected.
I used 'self: my_self_hostname.cdn.com'. This doesn't parse, no error is
logged but the strategy is destroyed in the NextHopStrategyFactory:143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
