rob05c edited a comment on pull request #8248: URL: https://github.com/apache/trafficserver/pull/8248#issuecomment-899882191
+1 on the PR, and also +1 on a test. This is definitely a good change, to serve stale when we can. Specifically the test should make sure the `Cache-Control: max-stale` and records.config `max_stale_age` are being respected. Looking at the code, it looks like they are, but we should be sure. We should also verify this behavior is in strategies and the parent_select plugin. Those of us talking about unifying the parent and non-parent paths in HttpTransact may also need to be aware of this. You don't need to worry about those, but I'll try to remember to bring it up at our next NextHop meeting, and/or verify and/or make an issue if they aren't -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
