ywkaras commented on a change in pull request #8208:
URL: https://github.com/apache/trafficserver/pull/8208#discussion_r694984543
##########
File path: iocore/net/SSLSNIConfig.cc
##########
@@ -166,13 +167,19 @@ SNIConfigParams::Initialize()
return 1;
}
- ts::Errata zret = Y_sni.loader(sni_filename);
+ YamlSNIConfig Y_sni_tmp;
+ ts::Errata zret = Y_sni_tmp.loader(sni_filename);
if (!zret.isOK()) {
std::stringstream errMsg;
errMsg << zret;
- Error("%s failed to load: %s", sni_filename, errMsg.str().c_str());
+ if (TSSystemState::is_initializing()) {
+ Emergency("%s failed to load: %s", sni_filename, errMsg.str().c_str());
+ } else {
+ Error("%s failed to load: %s", sni_filename, errMsg.str().c_str());
+ }
Review comment:
This logic may be common enough that we should add a new diag output
call, perhaps InitEmergency(), that blocks startup if initializing, but simply
logs an error otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
