SolidWallOfCode commented on a change in pull request #8235:
URL: https://github.com/apache/trafficserver/pull/8235#discussion_r698034072
##########
File path: plugins/header_rewrite/condition.h
##########
@@ -61,21 +61,22 @@ class Condition : public Statement
// Inline this, it's critical for speed (and only used twice)
bool
- do_eval(const Resources &res)
+ do_eval(const Resources &res, std::vector<std::string> &vector)
{
bool rt = eval(res);
+ vector = regex_sub_vector;
Review comment:
That does a copy of `regex_sub_vector`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
