masaori335 commented on a change in pull request #8201:
URL: https://github.com/apache/trafficserver/pull/8201#discussion_r698215133
##########
File path: proxy/http2/Http2ConnectionState.cc
##########
@@ -1677,6 +1677,8 @@ Http2ConnectionState::send_a_data_frame(Http2Stream
*stream, size_t &payload_len
payload_length = 0;
}
+ stream->update_sent_count(payload_length);
Review comment:
I'm +1 to set the EOS flag when it's possible. But I can't imagine
there're no more data to read but `payload_length` is not 0 because of this
logic.
```
1663 if (resp_reader->is_read_avail_more_than(0)) {
...
1676 } else {
1677 payload_length = 0;
1678 }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
