ywkaras commented on a change in pull request #8379:
URL: https://github.com/apache/trafficserver/pull/8379#discussion_r727381032



##########
File path: proxy/http/HttpSM.cc
##########
@@ -4957,6 +4957,10 @@ set_tls_options(NetVCOptions &opt, const 
OverridableHttpConfigParams *txn_conf)
       opt.verifyServerProperties = YamlSNIConfig::Property::NONE;
     }
   }
+
+  if (txn_conf->ssl_max_record_size != 0) {
+    opt.ssl_max_record_size = txn_conf->ssl_max_record_size;
+  }

Review comment:
       So it looks like set_tls_options() is only called in 
HttpSM::do_http_server_open().  Does that mean the override only impacts 
connections to the upstream server?  If so, the doc entry should note that I 
think.  If the session is a reused not a new one, will the override still take 
effect?  What about H2 to origin, where there are multiple active txns in 
different streams.  Will the override for the txn that causes the TLS 
connection to be made apply to later, overlapped txns in different streams?  
Or, will overrides for a txn for a later stream apply to the other txns in 
previously-started streams.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to