elsloo commented on a change in pull request #8501:
URL: https://github.com/apache/trafficserver/pull/8501#discussion_r745874059
##########
File path: plugins/cache_promote/configs.cc
##########
@@ -99,6 +99,10 @@ PromotionConfig::factory(int argc, char *argv[])
}
}
+ if (!_policy) {
Review comment:
This was the second of two `nullptr` checks written this way. I just
pushed a commit that changes this occurrence and the inverse check in the
destructor at the top of this file. Please take a look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
