SolidWallOfCode commented on pull request #8487: URL: https://github.com/apache/trafficserver/pull/8487#issuecomment-965940766
I think this is fine as a stop gap, but I have two things. 1. Why check the status code check for a valid value and not just non-zero? 2. Overall I think would be better to do better checking for the HTTP status being set after hooks. AFAIK this is checked only after remap, which is why this works there and not elsewhere. Setting the status to indicate an immediate return seems more robust than returning an error condition and then trying to clean up the resulting mess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
